-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Axel and Luna #180
Axel and Luna #180
Conversation
Do you wanna keep this open until you have sprites done? |
they have basic sprites in their glasses, but not the advanced texturing. i don't know how to go about that. for the finer details |
I'd prefer if everything was done when we merge it. |
technically it is done, however somebody has offered to improve the sprites |
could you improve the change log? Like adding the names of the drinks? |
Just a general question, does Floof allow adding two entirely separate mechanics in one PR? 'Cause this has drinks and the kiss and lick interactions in the same one. |
That is actually a very good point. Please split this up into multiple PRs. The Interactions can stay in the same PR just the drinks should go into it's own PR. Makes reviewing easier too. |
It seems like the PR was made on an incorrect branch. It contains commits from #179 and probably downstreams from it. |
ah, i think i had based this on the wrong branch i thought i had selected to use the main branch but i must have forgotten to change it or it didn't change like i thought it had before i created the next one. i will re-base. thank you |
f643984
to
41d1a5f
Compare
damit git stop being a pain in my ass |
hallelujah represents a player who is rare and hard to come by balanced some ethanol values
41d1a5f
to
a9f1b2d
Compare
I could do that, i just figured it would be better to not clog the log |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make a better changelog.
what would you like me to add? |
Look at @Mnemotechnician reply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All recipes work after playtesting
Added Axel's Ale, The Cute Captain, Jenn in Tonic, and Hallelujah
need somebody who can sprite to be able to help with this
no additional sprite needed for Hallelujah, this drink is intended to be very simple in its representation
🆑